[mqtt.homeassistant] Fix jinja usage in availability templates

[ccutrer]

Use the local Jinjava, instead of implicitly depending on the Jinja transformation service.

This was missed in the recent conversion to using Jinjava for transformations in "normal" channels.

[lsiepel]

Test fails.

[ccutrer]

Yes, but I don't understand why. The Homie itests are failing that it's unable to load the ChannelTransformation class, but that class is in the org.openhab.core.thing bundle. How on earth would that bundle not be available??

[lsiepel]

Yes, but I don't understand why. The Homie itests are failing that it's unable to load the ChannelTransformation class, but that class is in the org.openhab.core.thing bundle. How on earth would that bundle not be available??

Spend over an hour looking at this, but i also don;t understand why this is failing. Maybe @wborn can add anything as he knows way more about the itest's (no pressure ;-) )

[ccutrer]

I was able to get it to pass locally by importing ChannelTransformation in HomieThingHandler.java, (and adding a dummy method so Spotless doesn't remove the import):

    private void doNothing(ChannelTransformation transform) {
        System.out.println("Transform: " + transform.toString());
    }

Obviously that's not a proper solution, but it points to something about the Homie bundle not listing the ChannelTransformation class as a necessary import or something. I'm waaaay out of my Java depth with this, though.

[ccutrer]

@wborn: have you had a chance to look at this?

[wborn]

I think it's some Mockito bug. We could try upgrading Mockito and see if that helps.

[ccutrer]

I tried, but ran into the same thing as you! mockito/mockito#2708

[ccutrer]

Given that it seems like a Mockito upgrade is some ways away, I've added my dummy method workaround to get this PR through. We can revisit removing it if/when Mockito gets upgraded in core.

[lsiepel]

Thanks, the dummy method is a small price to move forward. It is well documented so LGTM