-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Bring back auto refresh for Weather Station and HomeCoach #16546
Conversation
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Regression of #16492 |
...ding.netatmo/src/test/java/org/openhab/binding/netatmo/internal/api/data/ModuleTypeTest.java
Show resolved
Hide resolved
Done |
@lolodomo - why did you remove the bug label? Since it also has the regression label, it won't be mentioned in release notes, but it's clearly a bug. |
Because the regression was introduced after the last release (milestone 1) and before the next release. So we don't want to mention it in next release as no user who installed milestone 1 was impacted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
It should not be mentioned when there is a "regression" label, that was the idea behind it. |
You mean if regression tag is there, we can keep the bug tag and the PR will not be in the release notes? |
Exactly, it will be filtered in milestone and final release notes. |
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: [email protected] <[email protected]>
…penhab#16546) * Corrects and completes PR openhab#16492 --------- Signed-off-by: [email protected] <[email protected]>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28 |
Resolves #16545
Showed that "netatmo:configurable" is no more used with the introduction of "netatmo:camera"
Proven by a test.