Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that qc_record.extras exists before accessing it #370

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Check that qc_record.extras exists before accessing it #370

wants to merge 3 commits into from

Conversation

ntBre
Copy link
Contributor

@ntBre ntBre commented Oct 21, 2024 •
edited
Loading

Description

Fixes #369

TODOs

  • reformat - I tried running pre-commit locally but it reformatted 100 files, so I'll just let CI handle it hopefully

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (a7cfc91) to head (16f6896).

Additional details and impacted files

@ntBre ntBre requested a review from j-wags October 21, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags Awaiting requested review from j-wags

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BaseRecord.extras is optional
1 participant
@ntBre