Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some android fixes and added additional hardware features. #1795

Closed
wants to merge 4 commits into from

Conversation

MAJigsaw77
Copy link
Contributor

@MAJigsaw77 MAJigsaw77 commented Jun 9, 2024

  • Use namespace in the app's Gradle file across all the Gradle projects to fix deprecation warnings.
  • Added Drop file event support by including the intent-filter reference and support for additional hardware features and USB device attachment.

- Updated `AndroidManifest.xml` to include new hardware features and improve compatibility.
- Added optional support for:
  - Bluetooth
  - Gamepad
  - USB host
  - PC-type external mouse input
  - Low latency audio
  - Pro audio
- Included a new intent filter for handling USB device attachment events.
- Ensured all new features are optional by setting `android:required="false"`.

These changes enhance the application's flexibility and compatibility with various input methods and devices, ensuring a better user experience across different hardware configurations.
@MAJigsaw77
Copy link
Contributor Author

screen-20240609-144625.mp4

This shows how the file drop works for android.

@moha0100110
Copy link

screen-20240609-144625.mp4
This shows how the file drop works for android.

pls can u make a haxe package that adds support for microphone capting pls we need it a lot

@player-03
Copy link
Contributor

player-03 commented Jun 13, 2024

-Added Drop file event support by including the intent-filter reference and support for additional hardware features and USB device attachment.

Since this is a new feature, it definitely goes in 8.2.0-Dev.

  • Use namespace in the app's Gradle file across all the Gradle projects to fix deprecation warnings.

Since this is fixing an issue, I'd say it could go on the develop branch. Though it isn't urgent, so 8.2.0-Dev is fine too. Either way, maybe make two different pull requests.

  • Updated AndroidManifest.xml to include new hardware features and improve compatibility.
  • Added optional support for:
    • Bluetooth
    • Gamepad
    • USB host
    • PC-type external mouse input
    • Low latency audio
    • Pro audio
  • Included a new intent filter for handling USB device attachment events.
  • Ensured all new features are optional by setting android:required="false".

These changes enhance the application's flexibility and compatibility with various input methods and devices, ensuring a better user experience across different hardware configurations.

I'm not convinced enough Lime apps use these to make them the default. Why not just set them on a per-app basis?

Add Bluetooth permission.

This means apps will be listed as using Bluetooth even when they actually don't. Could turn users off from downloading an app. Again, why not just set it on a per-app basis?

pls can u make a haxe package that adds support for microphone capting pls we need it a lot

This is off-topic for this thread. Please discuss it in the issue instead.

@MAJigsaw77
Copy link
Contributor Author

So, should i split the pr?

@MAJigsaw77
Copy link
Contributor Author

MAJigsaw77 commented Jun 13, 2024

Well, the third pr mostly adds things that most sdl apps have by default but if it's not suitable for apps, i can revert the commit.

(Most of them are also optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants