Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert lime.tools.Architecture to enum abstract. #1754

Merged
merged 7 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 100 additions & 10 deletions src/lime/tools/Architecture.hx
Original file line number Diff line number Diff line change
@@ -1,14 +1,104 @@
package lime.tools;

enum Architecture
import haxe.macro.Expr;
import hxp.HostArchitecture;

#if (haxe_ver >= 4.0) enum #else @:enum #end abstract Architecture(String) to String

{
ARMV5;
ARMV6;
ARMV7;
ARMV7S;
ARM64;
X86;
X64;
MIPS;
MIPSEL;
var ARMV5 = "ARMV5";
var ARMV6 = "ARMV6";
var ARMV7 = "ARMV7";
var ARMV7S = "ARMV7S";
var ARM64 = "ARM64";
var X86 = "X86";
var X64 = "X64";
var MIPS = "MIPS";
var MIPSEL = "MIPSEL";

public static function exists(architecture:String):Bool
{
switch (architecture)
{
case ARMV5, ARMV6, ARMV7, ARMV7S, ARM64, X86, X64, MIPS, MIPSEL:
return true;
default:
return false;
}
}

@:from private static function fromHostArchitecture(hostArchitecture:HostArchitecture):Architecture
{
if (hostArchitecture == HostArchitecture.ARMV6)
{
return ARMV6;
}
else if (hostArchitecture == HostArchitecture.ARMV7)
{
return ARMV7;
}
else if (hostArchitecture == HostArchitecture.ARM64)
{
return ARM64;
}
else if (hostArchitecture == HostArchitecture.X86)
{
return X86;
}
else /* if (hostArchitecture == HostArchitecture.X64) */
{
return X64;
}
}

@:from private static function fromString(string:String):Architecture
{
if (exists(string))
{
return cast string;
}
else
{
return null;
}
}

/**
Returns the given `Architecture` if available, or `null` otherwise.
**/
public inline function new(name:String)
{
this = fromString(name.toUpperCase());
}

public inline function is64():Bool
{
return this == ARM64 || this == X64;
}

public inline function isARM():Bool
{
return this.indexOf("ARM") == 0;
}

public inline function isMIPS():Bool
{
return this == MIPS || this == MIPSEL;
}

public inline function isX():Bool
{
return this == X86 || this == X64;
}

@:noCompletion public macro function match(self:Expr, expr:Expr):Expr
{
return macro switch ($self)
{
case $expr:
true;
default:
false;
};
}
}
12 changes: 6 additions & 6 deletions src/lime/tools/ProjectXMLParser.hx
Original file line number Diff line number Diff line change
Expand Up @@ -1160,21 +1160,21 @@ class ProjectXMLParser extends HXProject
case "architecture":
if (element.has.name)
{
var name = substitute(element.att.name);
var name = new Architecture(substitute(element.att.name));

if (Reflect.hasField(Architecture, name.toUpperCase()))
if (name != null)
{
ArrayTools.addUnique(architectures, Reflect.field(Architecture, name.toUpperCase()));
ArrayTools.addUnique(architectures, name);
}
}

if (element.has.exclude)
{
var exclude = substitute(element.att.exclude);
var exclude = new Architecture(substitute(element.att.exclude));

if (Reflect.hasField(Architecture, exclude.toUpperCase()))
if (exclude != null)
{
ArrayTools.addUnique(excludeArchitectures, Reflect.field(Architecture, exclude.toUpperCase()));
ArrayTools.addUnique(excludeArchitectures, exclude);
}
}

Expand Down
13 changes: 4 additions & 9 deletions tools/CommandLineTools.hx
Original file line number Diff line number Diff line change
Expand Up @@ -2234,17 +2234,12 @@ class CommandLineTools
{
if (argument.substr(0, 4) == "-arm")
{
try
{
var name = argument.substr(1).toUpperCase();
var value = Type.createEnum(Architecture, name);
var value = new Architecture(argument.substr(1));

if (value != null)
{
overrides.architectures.push(value);
}
if (value != null)
{
overrides.architectures.push(value);
}
catch (e:Dynamic) {}
}
else if (argument == "-64")
{
Expand Down
4 changes: 2 additions & 2 deletions tools/platforms/MacPlatform.hx
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ class MacPlatform extends PlatformTarget
project.architectures.remove(excludeArchitecture);
}

targetArchitecture = Type.createEnum(Architecture, Type.enumConstructor(System.hostArchitecture));
targetArchitecture = System.hostArchitecture;
for (architecture in project.architectures)
{
if (architecture.match(X86 | X64 | ARMV6 | ARMV7 | ARM64))
if (architecture.isARM() || architecture.isX())
{
targetArchitecture = architecture;
break;
Expand Down
Loading