Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove armv7 from default iOS target architectures #1734

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Dec 20, 2023

Fixes #1733. Nevermind.

Avoids the error no such file or directory: 'arm64' due to multiple architectures being passed in.

@player-03 player-03 closed this Dec 20, 2023
@player-03
Copy link
Contributor

I mean, we could remove it from the defaults for other reasons, but that's unrelated to the rebuild error.

@player-03 player-03 reopened this Dec 20, 2023
@player-03 player-03 changed the title Fix lime rebuild ios failure due to multiple architectures Remove armv7 from default iOS target architectures Dec 20, 2023
@player-03 player-03 closed this Dec 20, 2023
@tobil4sk tobil4sk deleted the fix/ios-rebuild branch December 20, 2023 21:12
@tobil4sk
Copy link
Member Author

The original error was caused by a bug in hxcpp, but maybe it makes sense to remove armv7 from the defaults anyway:
https://community.openfl.org/t/ios-armv7-architecture-is-deprecated/13698

@player-03
Copy link
Contributor

That thread seems to be talking about the build step, not rebuild, and I think they already removed it by default for that step. So rebuilding for armv7 isn't breaking anything, it just performs a bunch of unnecessary work.

If you undelete the branch, I can reopen the pull request.

@tobil4sk tobil4sk restored the fix/ios-rebuild branch December 21, 2023 18:41
@tobil4sk
Copy link
Member Author

The branch is restored.

@player-03 player-03 reopened this Dec 22, 2023
@player-03 player-03 merged commit c121dfd into openfl:develop Jan 18, 2024
78 checks passed
@tobil4sk tobil4sk deleted the fix/ios-rebuild branch January 18, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants