Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added android:appCategory. #1724

Closed
wants to merge 9 commits into from
Closed

Added android:appCategory. #1724

wants to merge 9 commits into from

Conversation

MAJigsaw77
Copy link
Contributor

This pr is basically making an app able to be detected as a game on android.

@MAJigsaw77 MAJigsaw77 changed the title Adding android:isGame. Added android:isGame. Nov 21, 2023
@MAJigsaw77
Copy link
Contributor Author

Is there anything wrong with the pr?

@player-03
Copy link
Contributor

The implementation looks fine, but it seems isGame is deprecated.

@MAJigsaw77
Copy link
Contributor Author

The implementation looks fine, but it seems isGame is deprecated.

Maybe i should implement that instead

@MAJigsaw77
Copy link
Contributor Author

@player-03 what should be as default value?

@MAJigsaw77 MAJigsaw77 changed the title Added android:isGame. Added android:appCategory. Dec 1, 2023
@joshtynjala
Copy link
Member

what should be as default value?

The Android docs say this:

Only define this value for apps that fit well into one of the specific categories.

With that in mind, by default, you shouldn't set it to any value. Just skip it entirely.

@MAJigsaw77 MAJigsaw77 mentioned this pull request Dec 2, 2023
Closed
@player-03
Rearrange AndroidPlatform.update().
3887275 
These two bits of code stood out among all the one-line assignments, so I figured there was somewhere better for both. I put the `if` block next to the other two `if` blocks and moved `ANDROID_LIBRARY_PROJECTS` to where it was used.
@MAJigsaw77
Copy link
Contributor Author

Will this be pushed?

@player-03
Copy link
Contributor

What do you think of #1735 as a solution?

@MAJigsaw77
Copy link
Contributor Author

What do you think of #1735 as a solution?

It's better then this implementation

@MAJigsaw77
Copy link
Contributor Author

You can close this if you want

@player-03
Copy link
Contributor

player-03 commented Dec 22, 2023 •
edited
Loading

Might leave this open until we get more feedback on my version. Edit: merged.

@player-03 player-03 closed this Jan 14, 2024
@MAJigsaw77 MAJigsaw77 deleted the patch-1 branch January 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MAJigsaw77 @player-03 @joshtynjala