Implement System.onTouchFile.
#35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I think I've found a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After taking another look at #28 and #27, I came up with another more general approach. Both PRs want to build a list of "touched" files, to be examined at the end of a Lime build. However, there's no reason
Systemhas to store this list. Instead,Systemcould dispatch a couple events, and Lime could build its own list out of that.Plus, there's potential for more uses. Anyone who wants to keep track of file operations can register their own event listener. Whereas both of the previous PRs are pretty tightly coupled to Lime.