feat: Add dig function #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What**
- Add a `dig` function that can be used to verify DNS resultion inside a
cluster. The function is implemented as a small bash script that
invokes `dig` and then returns the result as JSON or text, depending
on an ENV configuration. This function can also be used to demonstrate
how to lightly wrap the CLI tool and provide some logging to stderr
To test
```sh
$ faas-cli build --filter dig
$ docker run --name digtest --rm -p 8080:8080 ghcr.io/openfaas/dig:latest
$ curl localhost:8080 -d "google.com"
{"ip_address": "172.217.23.110"}
$ docker kill digtest
```
Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler
force-pushed
the
feat-add-dig-function
branch
from
ad2ad3f
to
abf502d
Compare
**What** - Update the docker login step from CI to use the same login action we use in all of the other OpenFaaS CI workflows. This brings consistency and avoids issues with changes in the Docker CLI that prevented login via stdin Signed-off-by: Lucas Roesler <[email protected]>
|
@alexellis i think i need a little to understand why the Docker login is failing? |
alexellis
reviewed
Sep 8, 2021
| docker login ghcr.io --username | ||
| ${{ steps.get_repo_owner.outputs.repo_owner }} | ||
| --password-stdin | ||
| - name: Login to Docker Registry |
There was a problem hiding this comment.
I think we can revert this part now, since master appears to be working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
digfunction that can be used to verify DNS resultion inside acluster. The function is implemented as a small bash script that
invokes
digand then returns the result as JSON or text, dependingon an ENV configuration. This function can also be used to demonstrate
how to lightly wrap the CLI tool and provide some logging to stderr
To test
Signed-off-by: Lucas Roesler [email protected]