Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openfaas ingress operator chart #666

Closed
wants to merge 1 commit into from

Conversation

viveksyngh
Copy link
Contributor

@viveksyngh viveksyngh commented Jun 28, 2020

This removes ingress operator from the openfaas helm chart and adds a new helm chart for the ingress operator

Description

Motivation and Context

  • I have raised an issue to propose this change (required)

#664

How Has This Been Tested?

I have tested this on Digital Ocean Kubernetes cluster

helm install openfaas openfaas -n openfaas --set basic_auth=true --set functionNamespace=openfaas-fn  --set generateBasicAuth=true --set serviceType=LoadBalancer
NAME: openfaas
LAST DEPLOYED: Sun Jun 28 19:01:37 2020
NAMESPACE: openfaas
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
To verify that openfaas has started, run:

  kubectl -n openfaas get deployments -l "release=openfaas, app=openfaas"
To retrieve the admin password, run:

  echo $(kubectl -n openfaas get secret basic-auth -o jsonpath="{.data.basic-auth-password}" | base64 --decode)

 kubectl -n openfaas get deployments -l "release=openfaas, app=openfaas"
NAME                READY   UP-TO-DATE   AVAILABLE   AGE
alertmanager        1/1     1            1           19s
basic-auth-plugin   1/1     1            1           19s
faas-idler          1/1     1            1           19s
gateway             1/1     1            1           19s
nats                1/1     1            1           19s
prometheus          1/1     1            1           19s
queue-worker        1/1     1            1           19s

helm install nginxingress  stable/nginx-ingress --set rbac.create=true
NAME: nginxingress
LAST DEPLOYED: Sun Jun 28 19:07:25 2020
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
The nginx-ingress controller has been installed.
It may take a few minutes for the LoadBalancer IP to be available.
You can watch the status by running 'kubectl --namespace default get services -o wide -w nginxingress-nginx-ingress-controller'

helm install ingress-operator ingress-operator --namespace=openfaas --set create=true
NAME: ingress-operator
LAST DEPLOYED: Sun Jun 28 19:09:36 2020
NAMESPACE: openfaas
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Thanks for installing ingress-operator. Please follow the instructions below to get you started.


kubectl get svc
NAME                                         TYPE           CLUSTER-IP       EXTERNAL-IP      PORT(S)                      AGE
kubernetes                                   ClusterIP      10.245.0.1       <none>           443/TCP                      3h50m
nginxingress-nginx-ingress-controller        LoadBalancer   10.245.148.215   138.197.238.72   80:32177/TCP,443:31267/TCP   5m56s
nginxingress-nginx-ingress-default-backend   ClusterIP      10.245.123.184   <none>           80/TCP                       5m56s

helm repo update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "inlets" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "openfaas" chart repository
...Successfully got an update from the "ingress-operator" chart repository
...Successfully got an update from the "nats-connector" chart repository
...Successfully got an update from the "openfaas/nats-connector" chart repository
...Successfully got an update from the "mqtt-connector" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈
➜  chart git:(master) ✗ helm install \
  --name cert-manager \
  --namespace cert-manager \
  --version v0.11.0 \
  jetstack/cert-manager
Error: unknown flag: --name
➜  chart git:(master) ✗ helm install cert-manager \
  --namespace cert-manager \
  --version v0.11.0 \
  jetstack/cert-manager
NAME: cert-manager
LAST DEPLOYED: Sun Jun 28 19:17:37 2020
NAMESPACE: cert-manager
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
cert-manager has been deployed successfully!

In order to begin issuing certificates, you will need to set up a ClusterIssuer
or Issuer resource (for example, by creating a 'letsencrypt-staging' issuer).

More information on the different types of issuers and how to configure them
can be found in our documentation:

https://docs.cert-manager.io/en/latest/reference/issuers.html

For information on how to configure cert-manager to automatically provision
Certificates for Ingress resources, take a look at the `ingress-shim`
documentation:

https://docs.cert-manager.io/en/latest/reference/ingress-shim.html
➜  chart git:(master) ✗ kubectl apply -f ../lets-encrypt-issuer.yml
issuer.cert-manager.io/letsencrypt-staging created
issuer.cert-manager.io/letsencrypt-prod created

 kubectl apply -f ../my-homepage.yml
functioningress.openfaas.com/myhomepagetls created
➜  chart git:(master) ✗ kubectl get ingress -n openfaas
NAME                        HOSTS                        ADDRESS   PORTS     AGE
cm-acme-http-solver-vljkc   my-homepage.viveksyngh.xyz             80        5s
myhomepagetls               my-homepage.viveksyngh.xyz             80, 443   10s

kubectl logs -n openfaas deploy/ingress-operator
I0628 13:39:45.404904       1 main.go:52] Starting FunctionIngress controller version: 0.6.2 commit: d3fc6dedbae581dfe1622f4792992f2b8bb60a7d
W0628 13:39:45.405323       1 client_config.go:543] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0628 13:39:45.407450       1 controller.go:122] Setting up event handlers
I0628 13:39:45.407666       1 controller.go:179] Waiting for informer caches to sync
I0628 13:39:45.508025       1 controller.go:184] Starting workers
I0628 13:39:45.508293       1 controller.go:190] Started workers
I0628 14:00:56.414237       1 controller.go:261] FunctionIngress name: myhomepagetls
I0628 14:00:56.414567       1 controller.go:270] fni.Spec.UseTLS() true
I0628 14:00:56.414667       1 controller.go:271] createIngress true

curl https://my-homepage.viveksyngh.xyz/
<html>Hello world</html>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.


- Install OpenFaaS

You must have a working OpenFaaS installation. You can find [instructions in the docs](https://docs.openfaas.com/deployment/kubernetes/#pick-helm-or-yaml-files-for-deployment-a-or-b), including instructions to also install OpenFaaS via Helm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ID of this section has changed to '#pick-arkade-helm-or-plain-yaml-files

@@ -1,5 +1,4 @@
{{- $functionNs := default .Release.Namespace .Values.functionNamespace }}
{{- if .Values.ingressOperator.create }}
{{- if .Values.create }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we always want to create these things now it's in it's own chart? (few files with this in)


replicas: 1

create: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we want to get rid of this value as this is explicitly True when installing this now

@alexellis
Copy link
Member

Didn't this happen @viveksyngh ?

@viveksyngh
Copy link
Contributor Author

I think this one was for migrating ingress operator to it's own helm chart.

@alexellis
Copy link
Member

We did this separately a while back so I'm closing the PR.

@alexellis alexellis closed this Nov 1, 2021
@alexellis
Copy link
Member

/lock

@derek derek bot locked and limited conversation to collaborators Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants