Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request error for empty user list responses #290

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Nov 14, 2023

This is backport from the master.

Description:

"An unexpected error occurred" if you try to get all responses when the users' list is empty:

  1. Open ORA Grading:

111

  1. In Search username fill in not existing student username:

222

  1. Click on View all responses:

333

I suggest not sending a request if the users are not on the list.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 14, 2023

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c644da3) to head (a643cae).

❗ Current head a643cae differs from pull request most recent head 8e3f8dd. Consider uploading reports for the commit 8e3f8dd to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/quince.master      #290   +/-   ##
============================================================
  Coverage                      100.00%   100.00%           
============================================================
  Files                             110       110           
  Lines                            1079      1080    +1     
  Branches                          159       160    +1     
============================================================
+ Hits                             1079      1080    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Nov 14, 2023
@mphilbrick211 mphilbrick211 requested a review from a team November 14, 2023 18:28
@mphilbrick211
Copy link

Hi @openedx/content-aurora! This is ready once the master is all set.

@feanil feanil removed the request for review from a team March 20, 2024 15:09
@arbrandes
Copy link
Contributor

Marking as draft until the fix is merged to master.

@DmytroAlipov
Copy link
Contributor Author

Hi, @arbrandes
Could you merge this PR so that this fix would be included in Quince 3.
Thank you

@DmytroAlipov DmytroAlipov marked this pull request as ready for review April 8, 2024 12:47
@mphilbrick211
Copy link

Hi @jansenk! Are you able to merge this for us?

@mariajgrimaldi
Copy link
Member

Hello @jansenk, could you help us merge this PR? I don't have write permissions for this repo, so I can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Backlog
Status: Ready to Merge
Development

Successfully merging this pull request may close these issues.

6 participants