fix: request error for empty user list responses

openedx · Mar 21, 2024 · a643cae · a643cae
1 parent c644da3
commit a643cae
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/src/containers/ListView/TableAction.jsx b/src/containers/ListView/TableAction.jsx
@@ -11,6 +11,7 @@ export const TableAction = ({ tableInstance, handleClick }) => (
     onClick={handleClick(tableInstance.rows)}
     variant="primary"
     className="view-all-responses-btn"
+    disabled={tableInstance.rows.length === 0}
   >
     <FormattedMessage {...messages.viewAllResponses} />
   </Button>

diff --git a/src/containers/ListView/__snapshots__/TableAction.test.jsx.snap b/src/containers/ListView/__snapshots__/TableAction.test.jsx.snap
@@ -3,6 +3,7 @@
 exports[`TableAction component snapshots 1`] = `
 <Button
   className="view-all-responses-btn"
+  disabled={false}
   onClick={[MockFunction]}
   variant="primary"
 >

diff --git a/src/data/redux/thunkActions/grading.js b/src/data/redux/thunkActions/grading.js
@@ -35,9 +35,11 @@ export const loadPrev = () => (dispatch) => {
  * @param {string[]} submissionUUIDs - ordered list of submissionUUIDs for selected submissions
  */
 export const loadSelectionForReview = (submissionUUIDs) => (dispatch) => {
-  dispatch(actions.grading.updateSelection(submissionUUIDs));
-  dispatch(actions.app.setShowReview(true));
-  dispatch(module.loadSubmission());
+  if (submissionUUIDs?.length > 0) {
+    dispatch(actions.grading.updateSelection(submissionUUIDs));
+    dispatch(actions.app.setShowReview(true));
+    dispatch(module.loadSubmission());
+  }
 };
 
 export const loadSubmission = () => (dispatch, getState) => {

diff --git a/src/data/redux/thunkActions/grading.test.js b/src/data/redux/thunkActions/grading.test.js
@@ -107,20 +107,25 @@ describe('grading thunkActions', () => {
       });
     });
     describe('loadSelectionForReview', () => {
-      const submissionUUIDs = [
-        'submission-id-0',
-        'submission-id-1',
-        'submission-id-2',
-        'submission-id-3',
-      ];
       test('dispatches actions.grading.updateSelection, actions.app.setShowReview(true), and then loadSubmission', () => {
+        const submissionUUIDs = [
+          'submission-id-0',
+          'submission-id-1',
+          'submission-id-2',
+          'submission-id-3',
+        ];
         thunkActions.loadSelectionForReview(submissionUUIDs)(dispatch, getState);
         expect(dispatch.mock.calls).toEqual([
           [actions.grading.updateSelection(submissionUUIDs)],
           [actions.app.setShowReview(true)],
           [thunkActions.loadSubmission()],
         ]);
       });
+      test('with empty submissionUUIDs does not dispatch any action', () => {
+        const submissionUUIDs = [];
+        thunkActions.loadSelectionForReview(submissionUUIDs)(dispatch, getState);
+        expect(dispatch).not.toHaveBeenCalled();
+      });
     });
   });