Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created date to subsidy serializer #301

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Sep 13, 2024

https://2u-internal.atlassian.net/browse/ENT-9498

Screenshot 2024-09-13 at 1 38 56 PM

Test plan

  1. Add a subsidy to http://localhost:18280/admin/subsidy/subsidy/
  2. check that the api response from the subsidy you just created returns "created" http://localhost:18280/api/v1/subsidies/?enterprise_customer_uuid=<enterprise_customer_uuid>

Description

Describe in a couple of sentences what this PR adds

Testing instructions

Add some, if applicable

Merge checklist

  • All reviewers approved
  • CI build is green
  • Documentation updated (not only docstrings)
  • Commits are squashed

@@ -51,7 +51,8 @@ class Meta:
"internal_only",
"revenue_category",
"is_active",
"total_deposits"
"total_deposits",
"created",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[consider] it might also be worth exposing modified date in this serializer, too? 🤔

@katrinan029 katrinan029 merged commit 104b867 into main Sep 17, 2024
7 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9498 branch September 17, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants