Data model for explicit storage of restricted runs and their courses #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
reviewed
Oct 8, 2024
...apps/catalog/migrations/0040_rename_json_metadata_contentmetadata__json_metadata_and_more.py
Outdated
Show resolved
Hide resolved
pwnage101
force-pushed
the
pwnage101/ENT-9569
branch
3 times, most recently
from
63f996d
to
d7a8efa
Compare
pwnage101
commented
Oct 9, 2024
Comment on lines
+59
to
+63
| migrations.AlterField( | ||
| model_name='catalogquery', | ||
| name='content_filter', | ||
| field=jsonfield.fields.JSONField(default=dict, dump_kwargs={'cls': jsonfield.encoder.JSONEncoder, 'ensure_ascii': False, 'indent': 4, 'separators': (',', ':')}, help_text="Query parameters which will be used to filter the discovery service's search/all endpoint results, specified as a JSON object.", load_kwargs={'object_pairs_hook': collections.OrderedDict}), | ||
| ), |
There was a problem hiding this comment.
why on earth is this being altered?
There was a problem hiding this comment.
I'll rebase on alex's PR to fix this. #967
pwnage101
force-pushed
the
pwnage101/ENT-9569
branch
2 times, most recently
from
46d70a8
to
c68ee7c
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9569
branch
4 times, most recently
from
ec06507
to
3d0d816
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9569
branch
from
3d0d816
to
045086f
Compare
pmakwana93
reviewed
Oct 10, 2024
| _json_metadata = {} # Callers are encouraged to set this. | ||
|
|
||
|
|
||
| class RestrictedRunAllowedForRestrictedCourseFactory(factory.django.DjangoModelFactory): |
There was a problem hiding this comment.
Q: so a content_key does not need to be passed in when instantiating a RestrictedRunAllowedForRestrictedCourseFactory obj?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9569