Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

chore(i18n): add more languages #98

Closed

Conversation

Yoiber071
Copy link

Add Transifex Working Group languages.

New language codes: it_IT,pt_PT,de_DE

@feanil
@natabene

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 14, 2023

Thanks for the pull request, @Yoiber071! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 14, 2023
@e0d
Copy link

e0d commented Feb 14, 2023

@mphilbrick211 tests run.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 16, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 3, 2023
@Yoiber071
Copy link
Author

Hi, Sorry for the late response, I've fixed the lint failures, and is ready to be tested again.

@coveralls
Copy link

coveralls commented Mar 6, 2023

Pull Request Test Coverage Report for Build 4948806493

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.198%

Totals Coverage Status
Change from base Build 4927060616: 0.0%
Covered Lines: 168
Relevant Lines: 307

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ade40a0) 58.08% compared to head (fb6b883) 58.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          26       26           
  Lines         396      396           
  Branches       66       66           
=======================================
  Hits          230      230           
  Misses        150      150           
  Partials       16       16           
Files Coverage Δ
src/i18n/index.js 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 6, 2023
@mphilbrick211
Copy link

Hi @chennighan2u! Would you mind reviewing this and merging if it's good-to-go? Thanks!

@mphilbrick211
Copy link

Hi @chennighan2u! Would you mind reviewing this and merging if it's good-to-go? Thanks!

Hi @chennighan2u friendly ping on this!

@mphilbrick211
Copy link

Hi @chennighan2u - just following up on this!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 12, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 15, 2023
@mphilbrick211
Copy link

Hi @chennighan2u and @openedx/masters-devs-cosmonauts! Can someone take a look at this and merge if all looks ok? Thanks!

@mphilbrick211
Copy link

Hi @openedx/masters-devs-cosmonauts! Just following up on this. Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 28, 2023
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 22, 2023
@mphilbrick211
Copy link

Hi @openedx/masters-devs-cosmonauts! Following up to see if someone could please get this reviewed/merged for us? Thanks!

@mphilbrick211
Copy link

Hi @openedx/masters-devs-cosmonauts! Just checking to see if there's an ETA on when this can be reviewed? Thanks!

@mphilbrick211
Copy link

Hi @openedx/masters-devs-cosmonauts! Would someone be able to review / merge this for us? You'll need to enable tests to run again.

@Yoiber071 Yoiber071 closed this Oct 20, 2023
@openedx-webhooks
Copy link

@Yoiber071 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Yoiber071 Yoiber071 reopened this Oct 20, 2023
@Yoiber071
Copy link
Author

Hi @mphilbrick211 I hope you're doing well, is there any update about it?

@mphilbrick211
Copy link

Hi @Yoiber071 - we have escalated this for review, but I don't have an ETA yet.

@openedx/masters-devs-cosmonauts @chennighan2u - is it possible to know if/when we can get this one reviewed? Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 23, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@mphilbrick211 mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants