Disable sorting on workbench (#900)

* Disable sorting on workbench * Address comments
opendistro-for-elasticsearch · Dec 9, 2020 · fb83526 · fb83526
1 parent 87160b3
commit fb83526
Show file tree

Hide file tree

Showing 4 changed files with 1,009 additions and 3,195 deletions.
diff --git a/workbench/public/components/QueryResults/QueryResults.test.tsx b/workbench/public/components/QueryResults/QueryResults.test.tsx
@@ -103,8 +103,9 @@ describe("<QueryResults with data/> spec", () => {
     // It tests Tab button
     await fireEvent.click(getAllByRole('tab')[5]);
 
+    // TODO: uncomment this test when sorting is fixed
     // It tests sorting
-    await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
+    // await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
 
     // It tests pagination
     await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);
@@ -209,8 +210,9 @@ describe("<QueryResults with data/> spec", () => {
     // It tests Tab button
     await fireEvent.click(getAllByRole('tab')[5]);
 
+    // TODO: uncomment this test when sorting is fixed
     // It tests sorting
-    await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
+    // await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]);
 
     // It tests pagination
     await fireEvent.click(getAllByLabelText('Page 2 of 2')[0]);

diff --git a/workbench/public/components/QueryResults/QueryResultsBody.tsx b/workbench/public/components/QueryResults/QueryResultsBody.tsx
@@ -601,9 +601,9 @@ class QueryResultsBody extends React.Component<QueryResultsBodyProps, QueryResul
         <EuiTableHeaderCell
           key={label}
           width={colwidth}
-          onSort={this.onSort.bind(this, label)}
-          isSorted={this.props.sortedColumn === label}
-          isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
+          // onSort={this.onSort.bind(this, label)}
+          // isSorted={this.props.sortedColumn === label}
+          // isSortAscending={this.props.sortableProperties.isAscendingByName(label)}
         >
           {label}
         </EuiTableHeaderCell>