Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove odc-geo workaround #1622

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Remove odc-geo workaround #1622

merged 4 commits into from
Aug 16, 2024

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

Remove workaround for odc-geo bug fixed in opendatacube/odc-geo#170 and released in odc-geo 0.4.8

  • Tests added / passed
  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (9faceaa) to head (aba1fcf).
Report is 1 commits behind head on develop-1.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1622      +/-   ##
===============================================
- Coverage        85.26%   85.26%   -0.01%     
===============================================
  Files              142      142              
  Lines            15606    15602       -4     
===============================================
- Hits             13307    13303       -4     
  Misses            2299     2299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -11,6 +11,7 @@ v1.9.next
- Permissions management cleanup in postgis driver. (:pull:`1613`)
- Add `skip_broken_datasets` and `dc_load_limit` config options. (:pull:`1616`)
- Enable global environment variables with `ODC_ALL` naming convention (:pull:`1616`)
- Remove workaround for an odc-geo bug that is now fixed. (:pull:`16??`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Remove workaround for an odc-geo bug that is now fixed. (:pull:`16??`)
- Remove workaround for an odc-geo bug that is now fixed. (:pull:`1622`)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes.

@SpacemanPaul SpacemanPaul merged commit e368532 into develop-1.9 Aug 16, 2024
24 of 25 checks passed
@SpacemanPaul SpacemanPaul deleted the test_odc_geo_fix branch August 16, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants