GHA: Update dockerhub credential passing mechanism. #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1528 +/- ##
========================================
Coverage 91.79% 91.79%
========================================
Files 132 132
Lines 14624 14624
========================================
Hits 13424 13424
Misses 1200 1200 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dockerhub GHA is failing because the secret was deleted? We probably shouldn't be using the gadockersvc account anyway.
I've made the dockerhub username a repo secret too so can switch more easily in future.
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1528.org.readthedocs.build/en/1528/