Rework tracon hash function #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Atomese backend can have 100K upper-case connectors, and no lower-case subscripts. This seems like a good compromise.
|
@ampli I'm merging this now, based on your earlier commentary. If this looks wrong, let me know. |
|
It seems there are still plenty of collisions, even with the new function. In tests conducted with just a small number of "normal" disjuncts, both this function and the original one led to significant collision problems, primarily in a few table entries that experienced the majority of collisions. Currently, I'm diving into debugging to figure this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for issue found in #1479
The Atomese backend can have 100K upper-case connectors, and no lower-case subscripts. This seems like a good compromise.