issue #628 save_user_coords #629
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxdimpf
force-pushed
the
save_user-coords
branch
3 times, most recently
from
88a83ba
to
2d3306a
Compare
wrygiel
requested changes
Nov 23, 2023
hxdimpf
force-pushed
the
save_user-coords
branch
2 times, most recently
from
091137a
to
ad8b421
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hxdimpf
force-pushed
the
save_user-coords
branch
2 times, most recently
from
cccc1cd
to
4a5f2f4
Compare
hxdimpf
force-pushed
the
save_user-coords
branch
from
4a5f2f4
to
b4cb1a9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hxdimpf
force-pushed
the
save_user-coords
branch
4 times, most recently
from
e8d3b16
to
0462c38
Compare
hxdimpf
force-pushed
the
save_user-coords
branch
from
0462c38
to
e24323f
Compare
|
If you want a feedback from c:geo side, please open an issue there. |
wrygiel
reviewed
Dec 9, 2023
hxdimpf
force-pushed
the
save_user-coords
branch
from
e24323f
to
5194518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about adding a new service endpoint. The platforms (opencaching.xx) provide the capabilities to maintain a personal cache notes field for each cache. In addition with this there is also a capability to store user provided coordinates for instance the coordinates that are the result of solving a puzzle.
The OKAPI provides a service to retrieve the personal caches notes and also the user_coords. It also provides a service to update the personal cache notes but not the user coords.
I have implemented a new service to fill this gap. First I thought about extending the already existing service
:: services/caches/save_personal_notes
however, to make sure that this doesn't create any adverse side effects for existing client applications I decided to implement a new service:
:: services/caches/save_user_coords.