Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take care of libraries #364

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schiermi
Copy link
Contributor

@schiermi schiermi commented Jun 7, 2024

  • Avoid compile time warnings from CircularBuffer like…
In file included from src/OpenBikeSensorFirmware.h:29,
                 from src/configServer.cpp:30:
.pio/libdeps/esp32dev/CircularBuffer/CircularBuffer.h:3:102: note: #pragma message: WARNING: please change import directive from CircularBiffer.h to CircularBuffer.hpp
 #pragma message("WARNING: please change import directive from CircularBiffer.h to CircularBuffer.hpp")

A build containing those changes was tested for three weeks "on the bike". Testing included track uploads & OBS Webinterface access.

platformio.ini Outdated
https://github.com/amandel/esp32_https_server.git#hotfix/openbikesensor
; TODO: https://github.com/jasenk2/esp32_https_server.git#esp_tls
; https://github.com/amandel/esp32_https_server.git#hotfix/openbikesensor
https://github.com/jasenk2/esp32_https_server.git#esp_tls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fork does not include the CN fix - when I remember correctly this was mainly needed for Apple devices.

fhessel/esp32_https_server@253013d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schiermi for the contribution!

@schiermi
Copy link
Contributor Author

schiermi commented Sep 10, 2024

OK, I missed the CN fix.
New approach based on the currently better maintained fork https://github.com/jackjansen/esp32_idf5_https_server with cherry-picked commits from https://github.com/amandel/esp32_https_server/tree/hotfix/openbikesensor. If tests with Apple devices work well, it should be worth a try to get the commits into https://github.com/jackjansen/esp32_idf5_https_server

I should be able to test certificates, generated based on this branch, with Apple devices in the next days.

@amandel
Copy link
Member

amandel commented Sep 14, 2024

Great! Would be good to find the one well maintained fork of the lib!

@schiermi
Copy link
Contributor Author

Verified successfully & opened PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants