Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dynamic Sample Rate Detection for Audio Compatibility #7

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix Dynamic Sample Rate Detection for Audio Compatibility #7

wants to merge 7 commits into from
+140 −14

Commits on Oct 1, 2024

  1. Fix broken links at README.md

    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4c7ed63 View commit details
    Browse the repository at this point in the history

  2. Update the WavRecorder and WavUpdate StreamPlayer instantiations with… 

    … dynamic sample rate detection.

Detect the system's default sample rate dynamically instead of hardcoding it to 24000 Hz, especially since Firefox is more sensitive to sample rate discrepancies.
    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b87b7df View commit details
    Browse the repository at this point in the history

  3. Update WavStreamPlayer constructor 

    Use the system's default sample rate when creating the audio context. This ensures that if no specific sample rate is provided, it will default to the system's preferred sample rate.
    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dd42bed View commit details
    Browse the repository at this point in the history

  4. Update the constructor in WavRecorder 

    Use the system's sample rate as the default if none is provided.
    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5bdbbcc View commit details
    Browse the repository at this point in the history

  5. Add resampling audio to 24,000 Hz

    @mmtmn
    mmtmn committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b0afd58 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary added comment on wav_recorder.js

    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    690cf02 View commit details
    Browse the repository at this point in the history

  7. Remove empty space after curly brackets

    @mmtmn
    mmtmn authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e46516e View commit details
    Browse the repository at this point in the history