Added function_get to source_schema_v2 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@macieg The plan is definitely to keep the schema in one place, just haven't gotten around to turning the OA repo/schema into a library that can be installed to give batch access. |
This was referenced Oct 20, 2020
Merged
|
I've updated the OA repo to expose the schema as a library. I'm going to close this PR in favour of using the library directly Ref: #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of openaddresses/machine#766
I want to check if the new function_get will work in CI. Now I cannot check it, because batch own copy of schema.
draft here -> openaddresses/openaddresses@ff5e713
Isn't it a good idea to keep the schema in just one place?