Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce download-retry and download-retry-wait settings in ZConfig #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bzeller
Copy link
Contributor

@bzeller bzeller commented Jun 14, 2022

No description provided.

@bzeller bzeller marked this pull request as ready for review June 14, 2022 10:51
@@ -37,6 +37,10 @@ SET( zypp_toplevel_SRCS
)
INSTALL( FILES ${zypp_toplevel_headers} DESTINATION "${INCLUDE_INSTALL_DIR}/zypp-core" )

SET( zypp_base_private_HEADERS
base/private/configoption_p.h
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ripping out the struct Options, placing them in a new header file and adding the header file to CMake schoul go into a separate commit. That's pure cleanup and not related to any fix.


void set_download_max_silent_tries( long val, bool overrideDefault = false ) {
if ( val < 0 ) val = 0;
else if ( val > 10 ) val = 10;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you introduce new limit's, then it must be documented. The accessor in ZConfig.h schould mention it. If it is also exposed in zypp.conf we should think twice whether we need to introduce a restriction (an break existing behavior). If so, it must be documented in the zypp.conf template we install in the system and the zypper man page must be checked, whether it mentions the value. And we need a good explanation why?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants