Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme File #1780

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update Readme File #1780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ This will ensure that the Git hooks are installed on your local machine.**</br>

*Or Run the `ci-prebuild.sh` or `ci-prebuild.bat` script to run all the above commands in one go.*

5. **Install JDK**

You need to install any JDK version between 17...21

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you provide step by step instructions with images for updating or installing JDK


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think as we configured the Jvm toolchain it will automatically download and configure the JDK..no need to install manually can you test it by uninstalling your JDK or change to some different version and try to run the project and let me know if it's work.. by running ci-prepush.sh script ..

### **Committing Your Changes**

When you've finished making your changes and have tested them locally, it's time to commit your work:
Expand Down
1 change: 1 addition & 0 deletions build-logic/convention/src/main/kotlin/org/mifospay/KotlinAndroid.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,6 @@ private inline fun <reified T : KotlinTopLevelExtension> Project.configureKotlin
freeCompilerArgs.add(
"-opt-in=androidx.compose.material3.ExperimentalMaterial3Api"
)
jvmToolchain(17)
}
}
Loading