Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type: fix #1409

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Type: fix #1409

merged 2 commits into from
Oct 19, 2023

Conversation

Sarthak9504
Copy link
Contributor

@Sarthak9504 Sarthak9504 commented Oct 4, 2023

Subject: Fixed issue #1368 change in MobileVerificationActivity
Body: When the user clicks on the fab_next button it was verifying the empty OTP without checking user has entered the OTP in the Edit Text or not and navigating to the next page.

Issue Fix

Fixes #1368

Screenshots

WhatsApp Image 2023-10-05 at 02 35 14_73d4a07a

Description

I have added an if statement followed by ab else block the if statement checks whether the user has entered the OTP or it is empty if not then it displays a toast message when user tries to verify navigate to the next page.

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Subject: Fix the Mobile(OTP) not working effectively
Body: The users were able to navigate to the next page without entering the OTP, so there needed to be a provision to check whether user has entered the OTP before verifying
Subject: Fix the Mobile(OTP) not working effectively
Body: The users were able to navigate to the next page without entering the OTP, so there needed to be a provision to check whether user has entered the OTP before verifying
@Sarthak9504
Copy link
Contributor Author

Hello i am new to open source community I have tried my best to keep the PR aligned with the contribution guidelines if my PR in any form violates the contribution guidelines please do inform me so that I don't repeat the same mistake again

@Sarthak9504
Copy link
Contributor Author

Hello can anyone tell me how can i apply AndroidStyle.xml template to my Android Studio

@Sarthak9504
Copy link
Contributor Author

Hey @vorburger please review my PR

@vorburger
Copy link
Member

Hey @vorburger please review my PR

Hey @Sarthak9504 I'm not an active committer / reviewer / contributor on this repository.

I can see that this project has a (huge...) backlog of pending PRs, which nobody seems to be reviewing anymore...

... if I were you, I would try to reach out to the Mifos Community via the respective mailing lists and chat, to try to find people willing to review this (and other pending PRs). Or maybe it's time for the last previous committers to "open the door" and invite a new next generation, to keep maintaining this repository!

Do you know how to do that?

@Sarthak9504
Copy link
Contributor Author

@vorburger if this is the case then can you guide me how do I contact them on mailing lists, do you have any kind of link or something

@vorburger
Copy link
Member

https://openmf.github.io/mobileapps.github.io/ doesn't seem to have any Contacts section (but should have).

https://github.com/openMF mentions [email protected]; you could try? (I'm not sure if you'll get a response.)

Try https://mifos.org/take-action/volunteer/ and see what happens?

https://mifos.org/about-us/contact-us/ has Mailing List (but link is broken; but as far as I know there is a [email protected] list which you could try?), a Live Chat (also broken), and https://bit.ly/mifos-slack-space which is probably most promising?

@Sarthak9504
Copy link
Contributor Author

@vorburger thank you so much!

@IOhacker IOhacker merged commit 22d3ae8 into openMF:dev Oct 19, 2023
3 of 4 checks passed
@Sarthak9504 Sarthak9504 deleted the fix-bug-1368 branch October 20, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile(OTP) verification is not working effectively
3 participants