Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign: Login Page #1399

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Redesign: Login Page #1399

merged 1 commit into from
Aug 19, 2023

Conversation

rchtgpt
Copy link
Member

@rchtgpt rchtgpt commented Aug 9, 2023 •
edited
Loading

Issue Fix

Fixes #1398

Screenshot of Implementation

image

Description

  • Realized that we might not have a Forgot Password API yet so had to remove the option to do that.
  • Aligned the "Don't have an account? Create one" text to the bottom of the page to give it visual weight in the hierarchy.

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@rchtgpt rchtgpt requested a review from luckyman20 August 9, 2023 07:45
luckyman20
luckyman20 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luckyman20 luckyman20 merged commit a67c037 into openMF:redesign-2023 Aug 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckyman20 luckyman20 luckyman20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchtgpt @luckyman20