Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry sub-commands #30

Merged

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Feb 17, 2024

This PR sets up the registry command and defines a list of sub-commands (i.e., check, generate, resolve, search, stats). Only the check command is implemented (see #26).

All other existing commands have been placed behind the experimental feature flag so as not to appear by default.

A brief description of the semantic convention registry resolution process has been added to the README.md of the weaver_resolver crate. Unimplemented elements are also identified (i.e., any_of, include). The completion and full testing of the registry resolution process will be the subject of a future PR.

@lquerel lquerel added the enhancement New feature or request label Feb 17, 2024
@lquerel lquerel self-assigned this Feb 17, 2024
src/registry/mod.rs Show resolved Hide resolved
src/registry/search.rs Show resolved Hide resolved
src/registry/stats.rs Show resolved Hide resolved
@jsuereth jsuereth merged commit 3504e89 into open-telemetry:main Feb 17, 2024
14 checks passed
@lquerel lquerel deleted the 26-weaver-registry-check-subcommand branch April 4, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants