Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Move supplementary-guidelines into docs #1284

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 25, 2024

Screenshot

This is what it will look like on the OTel website once integrated:

image

@chalin chalin requested review from a team July 25, 2024 23:43
@chalin chalin force-pushed the chalin-im-supp-guide-to-docs-non-normative-2024-07-25 branch from a5b1c86 to 5f34f03 Compare July 25, 2024 23:44
@chalin chalin force-pushed the chalin-im-supp-guide-to-docs-non-normative-2024-07-25 branch from 5f34f03 to c172179 Compare July 25, 2024 23:47
@chalin
Copy link
Contributor Author

chalin commented Jul 25, 2024

/cc @open-telemetry/docs-maintainers

@joaopgrassi
Copy link
Member

@chalin did you also intend to move the HTTP migration guide document as part of this PR? I don't see it in the changes 🤔 #1234

@joaopgrassi joaopgrassi added the Skip Changelog Label to skip the changelog check label Jul 26, 2024
@chalin
Copy link
Contributor Author

chalin commented Jul 26, 2024

@chalin did you also intend to move the HTTP migration guide document as part of this PR? I don't see it in the changes 🤔 #1234

LOL ... the whole reason for this change! For some reason, in the back of my mind, that page was already a part of the supp. guidelines 🤷🏼‍♂️. I'm moving the HTTP migration page now.

Signed-off-by: Patrice Chalin <[email protected]>
@chalin chalin requested a review from a team July 26, 2024 15:10
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
@chalin
Copy link
Contributor Author

chalin commented Jul 26, 2024

Ready for a final review @joaopgrassi et al.

@joaopgrassi joaopgrassi merged commit de25ecb into open-telemetry:main Jul 29, 2024
12 checks passed
@chalin chalin deleted the chalin-im-supp-guide-to-docs-non-normative-2024-07-25 branch July 29, 2024 11:48
maryliag pushed a commit to maryliag/semantic-conventions that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[editorial] Move supplementary-guidelines to be under docs
5 participants