-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit system network metrics attributes #308
Comments
The other thing that came up was about the
So if we revisit the attributes, we need to look at this one as well. |
Thanks. That should go to another cpu related issue |
I am moving this to blocked since I want to have a clear picture of #394, since I think questions like #330 (comment) may arise here |
Moving back to Todo, we have treated #394 as a MUST, but it is still unclear and would help if it's resolved to make progress here cc @joaopgrassi |
Bumping this up. I see that most of the initial concerns should now be covered: network.direction It has been renamed to system.device Still network.protocol It has been renamed to system.network.state Still From the above I only see the Otherwise we can consider it as completed. |
One question that pops up is if we should use the |
We discussed about
/cc @open-telemetry/semconv-system-approvers @open-telemetry/semconv-k8s-approvers |
Systems WG discussed that in Oct 17th meeting. We agreed that a |
Context
This issue is a follow-up to https://github.com/open-telemetry/semantic-conventions/pull/89/files#r1299769832. We need to take the opportunity of the attribute renaming required for #51 and choose names that inspire full confidence. The goal is to open a discussion and reach consensus on attribute names that minimize the risk of future changes.
All Network Metrics Attributes (Old Name / Current Name):
device
->system.device
direction
->system.network.direction
protocol
->network.protocol
state
->system.network.state
We should revisit each of these attributes within the scope of this issue. If you have any ideas or suggestions, please comment. The following are the main concerns we should address:
protocol
/network.protocol
We picked
network.protocol
because it's generic and can be applicable to other metrics. It's listed in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#network-attributes. We should rename it tonetwork.protocol.name
then.state
/system.network.state
While it currently sounds like a state of the network, in the OTel collector host metrics receiver, it represents connection status (e.g., "CLOSED," "LISTEN," ESTABLISHED," etc.). I think we should rename it to
network.connection.status
and add it to https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attributes.md#network-attributes.The text was updated successfully, but these errors were encountered: