Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system.device vs device.id vs hw.id #1474

Open
lmolkova opened this issue Oct 14, 2024 · 4 comments
Open

system.device vs device.id vs hw.id #1474

lmolkova opened this issue Oct 14, 2024 · 4 comments

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Oct 14, 2024

See #1408 (comment) for the context

  • device.id is an id of a mobile device (or another device on which instrumented process is running)
  • hw.id is an id of a hardware component
  • system.device is an id of a virtual or physical component such as disk, network interface, etc

The proposal is to

  • merge hw.id and system.device into a new attribute that would represent physical or virtual component and can be reused in HW and system metrics
  • if for some reason it's not possible, the system.device should be elaborated and should include the property being described (e.g. system.device.id or system.device.name)
@joaopgrassi
Copy link
Member

In here https://github.com/open-telemetry/semantic-conventions/pull/1413/files#diff-abc3e1468589797073cc2e0fcb7620efd3e94bf4c37ac3e669c7793f0ed226acR18 there's also dc.device.type, so another "duplication"

@ChrsMark
Copy link
Member

What would be the difference between system.device.id and system.device.name?

@joaopgrassi
Copy link
Member

joaopgrassi commented Oct 15, 2024

I guess it's just so we have a way to represent a "real" id and a read-friendly version of the device. But probably the most important thing is that system.device stops being an attribute and becomes a namespace. We are trying to avoid such cases as we have had problems in the past.

@ChrsMark
Copy link
Member

system.device is an id of a virtual or physical component such as disk, network interface, etc

regarding network interfaces there is a related discussion: #308 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants