removed unsafe build flags #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachoBonafonte
approved these changes
Jun 6, 2024
vvydier
approved these changes
Jun 6, 2024
bryce-b
added a commit
to bryce-b/opentelemetry-swift
that referenced
this pull request
Jul 22, 2024
bryce-b
added a commit
that referenced
this pull request
Jul 22, 2024
* Bridge: Logging Bridge for SwiftLog * add more config options * corrected failures from build * corrected failures from build * attribute conversion * set loglevel and metadata * fix build errors * applied patch for build fail * Added test for the LogHandler file * Update LogHandlerTests.swift * Update Package.swift * Update [email protected] * Update [email protected] * Update LogHandler.swift fixed log emitter * Update LogHandlerTests.swift * Update LogHandler.swift access change to accommodate tests. * removed unsafe build flags (#545) * Update LogHandlerTests.swift Added Tests * Added support for embedded arrays for AttributeValues. * resolved pr review requests * restored typed arrays in AttributeValue object * removed dependency on SDK from OtelSwiftLog * upped test timeouts to solve inconsistent failures * changed iphone simulator * disabled flaky tests --------- Co-authored-by: khushijain21 <[email protected]> Co-authored-by: EROMOSELE AKHIGBE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.