Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing access control level for few methods in SpanAdapter #480

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public struct SpanAdapter {
return protoSpan
}

static func toProtoSpanKind(kind: SpanKind) -> Opentelemetry_Proto_Trace_V1_Span.SpanKind {
public static func toProtoSpanKind(kind: SpanKind) -> Opentelemetry_Proto_Trace_V1_Span.SpanKind {
switch kind {
case .internal:
return Opentelemetry_Proto_Trace_V1_Span.SpanKind.internal
Expand All @@ -82,7 +82,7 @@ public struct SpanAdapter {
}
}

static func toProtoSpanEvent(event: SpanData.Event) -> Opentelemetry_Proto_Trace_V1_Span.Event {
public static func toProtoSpanEvent(event: SpanData.Event) -> Opentelemetry_Proto_Trace_V1_Span.Event {
var protoEvent = Opentelemetry_Proto_Trace_V1_Span.Event()
protoEvent.name = event.name
protoEvent.timeUnixNano = event.timestamp.timeIntervalSince1970.toNanoseconds
Expand All @@ -92,7 +92,7 @@ public struct SpanAdapter {
return protoEvent
}

static func toProtoSpanLink(link: SpanData.Link) -> Opentelemetry_Proto_Trace_V1_Span.Link {
public static func toProtoSpanLink(link: SpanData.Link) -> Opentelemetry_Proto_Trace_V1_Span.Link {
var protoLink = Opentelemetry_Proto_Trace_V1_Span.Link()
protoLink.traceID = TraceProtoUtils.toProtoTraceId(traceId: link.context.traceId)
protoLink.spanID = TraceProtoUtils.toProtoSpanId(spanId: link.context.spanId)
Expand All @@ -102,7 +102,7 @@ public struct SpanAdapter {
return protoLink
}

static func toStatusProto(status: Status) -> Opentelemetry_Proto_Trace_V1_Status {
public static func toStatusProto(status: Status) -> Opentelemetry_Proto_Trace_V1_Status {
var statusProto = Opentelemetry_Proto_Trace_V1_Status()
switch status {
case .ok:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class OtlpTraceJsonExporter: SpanExporter {
private var isRunning: Bool = true

// MARK: - Json Exporter helper methods
func getExportedSpans() -> [OtlpSpan] {
public func getExportedSpans() -> [OtlpSpan] {
exportedSpans
}

Expand Down
Loading