Use the correct instrument type while creating aysnchronous instruments #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunguyenaxon
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
hunguyenaxon
commented
Oct 9, 2023
| registerDoubleAsynchronousInstrument(type: .counter, updater: callback) | ||
| public func buildWithCallback(_ callback: @escaping (OpenTelemetryApi.ObservableDoubleMeasurement) -> Void) | ||
| -> OpenTelemetryApi.ObservableDoubleCounter { | ||
| registerDoubleAsynchronousInstrument(type: .observableCounter, updater: callback) |
There was a problem hiding this comment.
Main change: .counter -> .observableCounter
hunguyenaxon
commented
Oct 9, 2023
| registerDoubleAsynchronousInstrument(type: type, updater: callback) | ||
| public func buildWithCallback(_ callback: @escaping (OpenTelemetryApi.ObservableDoubleMeasurement) -> Void) | ||
| -> OpenTelemetryApi.ObservableDoubleUpDownCounter { | ||
| registerDoubleAsynchronousInstrument(type: .observableUpDownCounter, updater: callback) |
There was a problem hiding this comment.
Main change: type -> . observableUpDownCounter
hunguyenaxon
commented
Oct 9, 2023
| registerLongAsynchronousInstrument(type: type, updater: callback) | ||
| public func buildWithCallback(_ callback: @escaping (OpenTelemetryApi.ObservableLongMeasurement) -> Void) | ||
| -> OpenTelemetryApi.ObservableLongCounter { | ||
| registerLongAsynchronousInstrument(type: .observableCounter, updater: callback) |
There was a problem hiding this comment.
Main change: type -> . observableCounter
hunguyenaxon
commented
Oct 9, 2023
| registerLongAsynchronousInstrument(type: type, updater: callback) | ||
| public func buildWithCallback(_ callback: @escaping (OpenTelemetryApi.ObservableLongMeasurement) -> Void) | ||
| -> OpenTelemetryApi.ObservableLongUpDownCounter { | ||
| registerLongAsynchronousInstrument(type: .observableUpDownCounter, updater: callback) |
There was a problem hiding this comment.
Main change: type -> . observableUpDownCounter
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
bryce-b
approved these changes
Oct 9, 2023
vvydier
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is for #471
While creating asynchronous instrument from synchronous one, we need to pass the correct
InstrumentTypeinstead of using the value of synchronous instance.