Skip to content

Commit

Permalink
removed dependency on SDK from OtelSwiftLog
Browse files Browse the repository at this point in the history
  • Loading branch information
bryce-b committed Jul 22, 2024
1 parent 933ec3c commit e7f66af
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ let package = Package(
.target(name: "OpenTelemetrySdk",
dependencies: ["OpenTelemetryApi"]),
.target(name: "OTelSwiftLog",
dependencies: ["OpenTelemetrySdk",
dependencies: ["OpenTelemetryApigi",
.product(name: "Logging", package: "swift-log")],
path: "Sources/Bridges/OTelSwiftLog"),
.target(name: "ResourceExtension",
Expand Down
2 changes: 1 addition & 1 deletion [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ let package = Package(
path: "Sources/Instrumentation/SDKResourceExtension",
exclude: ["README.md"]),
.target(name: "OTelSwiftLog",
dependencies: ["OpenTelemetrySdk",
dependencies: ["OpenTelemetryApi",
.product(name: "Logging", package: "swift-log")],
path: "Sources/Bridges/OTelSwiftLog"),
.target(name: "URLSessionInstrumentation",
Expand Down
2 changes: 1 addition & 1 deletion [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ let package = Package(
.target(name: "OpenTelemetrySdk",
dependencies: ["OpenTelemetryApi"]),
.target(name: "OTelSwiftLog",
dependencies: ["OpenTelemetrySdk",
dependencies: ["OpenTelemetryApi",
.product(name: "Logging", package: "swift-log")],
path: "Sources/Bridges/OTelSwiftLog"),
.target(name: "ResourceExtension",
Expand Down
3 changes: 1 addition & 2 deletions Sources/Bridges/OTelSwiftLog/LogHandler.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import Foundation
import OpenTelemetryApi
import OpenTelemetrySdk
import Logging

// let the bridgename be the url of the package?
Expand Down Expand Up @@ -37,7 +36,7 @@ struct OTelLogHandler: LogHandler {
/// - Parameter loggerProvider: The logger provider to use in the bridge. Defaults to the global logger provider.
/// - Parameter includeTraceContext : boolean flag used for the logger builder
/// - Parameter attributes: attributes to apply to the logger builder
public init(loggerProvider: LoggerProvider = OpenTelemetrySdk.LoggerProviderSdk(),
public init(loggerProvider: LoggerProvider = OpenTelemetryApi.DefaultLoggerProvider.instance,
includeTraceContext : Bool = true,
attributes: [String:AttributeValue] = [String:AttributeValue]()) {

Expand Down

0 comments on commit e7f66af

Please sign in to comment.