Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the new user-facing Logs API as a placeholder #4236

Merged
merged 34 commits into from
Oct 9, 2024

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Oct 1, 2024

specification/README.md Outdated Show resolved Hide resolved
@MSNev MSNev force-pushed the MSNev/PublicLogsApi branch 3 times, most recently from 1929a39 to 9d9c8f2 Compare October 1, 2024 18:05
specification/logs/event-api.md Outdated Show resolved Hide resolved
specification/logs/event-sdk.md Outdated Show resolved Hide resolved
specification/logs/event-api.md Outdated Show resolved Hide resolved
specification/logs/event-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/bridge-api.md Outdated Show resolved Hide resolved
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(editorial suggestions only)

specification/logs/bridge-api.md Outdated Show resolved Hide resolved
specification/logs/event-api.md Outdated Show resolved Hide resolved
specification/logs/event-api.md Outdated Show resolved Hide resolved
specification/logs/event-sdk.md Outdated Show resolved Hide resolved
specification/logs/event-sdk.md Outdated Show resolved Hide resolved
specification/logs/sdk.md Outdated Show resolved Hide resolved
MSNev and others added 17 commits October 2, 2024 17:42
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Copy link
Contributor

@tedsuo tedsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's get this merged and add the API method.

@MSNev
Copy link
Contributor Author

MSNev commented Oct 7, 2024

@trask, @lmolkova, @pellared can you please check the latest commit, it (should) include

  • all of your suggested changes (which I committed from github)
  • As per discussion in the Maintainers meeting (general agreement of calling it the "Logs Instrumentation API"), updated the missed renames as per Trasks commits from last week.

Process taken: Merged changes from remote branch (which included the commits), updated missed renamings and pushed them back out (leading to loads of listed "commits" -- which should just be duplicative), I normally "cleanup" and squash the commits locally to keep it clean, but that requires a forced push to my branch and I didn't want to do that for this PR, hence the "messy" looking commits.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may want to just call it the "Logs API" (which is enough to differentiate it from the "Logs Bridge API"), but I can propose that in a follow-up.

@lmolkova lmolkova merged commit b9d347a into open-telemetry:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants