HTTP client span clarification #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
commented
Mar 6, 2023
mateuszrzeszutek
force-pushed
the
clarify-resends
branch
from
18526d0
to
49ffcda
Compare
trask
approved these changes
Mar 10, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
lmolkova
reviewed
Mar 20, 2023
lmolkova
reviewed
Mar 20, 2023
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
arminru
added
semconv:HTTP
area:semantic-conventions
trask
reviewed
Apr 7, 2023
lmolkova
approved these changes
Apr 7, 2023
denisivan0v
approved these changes
Apr 7, 2023
carlosalberto
approved these changes
Apr 11, 2023
|
@mateuszrzeszutek Can we add a CHANGELOG entry? Even though it's a clarification, it's an important one. |
mateuszrzeszutek
force-pushed
the
clarify-resends
branch
from
bd5d178
to
14cb3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/semantic-conventions#1226 and #3234
Changes
This PR contains the less controversial parts of #3234; it describes how the
http.resend_countattribute should be used, and proposes two ways of instrumenting HTTP clients.CC @trask @lmolkova