Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration test #2219

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 18, 2024

Fixes #

Changes

seems something has changed in latest rust toolchain, and cargo needs to be executed from the package root. While the integration tests are running now, the test itself is failing. Will be fixing that in this PR.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 18, 2024 00:46
@lalitb lalitb added the integration tests Run integration tests label Oct 18, 2024
@cijothomas
Copy link
Member

While the integration tests are running now, the test itself is failing. Will be fixing that in this PR

Did you mean fixing will be in this PR or a separate PR

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (e6965bd) to head (e2819ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2219   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        122     122           
  Lines      20986   20986           
=====================================
  Hits       16623   16623           
  Misses      4363    4363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Oct 18, 2024

While the integration tests are running now, the test itself is failing. Will be fixing that in this PR

Did you mean fixing will be in this PR or a separate PR

Ops i meant separate PR.

@lalitb lalitb merged commit f677458 into open-telemetry:main Oct 18, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants