Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update otel versions for prometheus to 0.26 #2183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ouertani
Copy link

@ouertani ouertani commented Oct 8, 2024

Fixes #
Design discussion issue (if applicable) #
align opentelemetry-prometheus to 0.26.0 version

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • [ x] Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ouertani ouertani requested a review from a team as a code owner October 8, 2024 17:18
Copy link

linux-foundation-easycla bot commented Oct 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please update changelog.md too.

Also, see #1957 (review)
No change in Prometheus status - it may not work in next release! if it works, they good, but no guarantees.

@cijothomas cijothomas changed the title feat: update otel versions for promo to 0.26 feat: update otel versions for prometheus to 0.26 Oct 8, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (4852a5e) to head (c765d52).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2183   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        121     121           
  Lines      20944   20933   -11     
=====================================
- Hits       16612   16611    -1     
+ Misses      4332    4322   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Oct 15, 2024

@ouertani Do you want to look into the CI tests for Prometheus which are failing right now ?

@ouertani
Copy link
Author

@ouertani Do you want to look into the CI tests for Prometheus which are failing right now ?

Yes, I will try to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants