fix: Remove Metrics OTLP exporter Util#measure_request_duration and duplicate files
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTLP metrics exporter does not use the metrics reporter present in the traces OTLP exporter. The measure_request_duration method is used in the traces exporter to provide a value for the metrics reporter. Since the metrics OTLP exporter does not use this metrics reporter, the method is not needed. Also, with the current code, the duration was being calculated in a void context. The value of the response variable has been and should be the result of @http.request(request).
There were some duplicate files at the path exporter/otlp/* that were no longer used, now that the files are nested under exporter/otlp/metrics/* The test file location was updated to reflect the new location.
kaylareopelle
changed the title
Util#measure_request_durationUtil#measure_request_duration and duplicate files
kaylareopelle
changed the title
Util#measure_request_duration and duplicate filesUtil#measure_request_duration and duplicate files from old nesting structure
kaylareopelle
changed the title
Util#measure_request_duration and duplicate files from old nesting structureUtil#measure_request_duration and duplicate files
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
mwear
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the recent Rubocop failures, I learned two things:
measure_request_durationin the metrics OTLP exporter because we don't use the metrics reporter.exporter/otlp/*) still existed (we now useexporter/otlp/metrics/*).Both of these issues are fixed in this PR.