Rubocop on metrics

exporter/otlp-metrics/.rubocop.yml

@@ -1,32 +1,21 @@
+inherit_from: ../../contrib/rubocop.yml
+
 AllCops:
-  TargetRubyVersion: "3.0"
-  NewCops: disable
-  SuggestExtensions: false
   Exclude:
     - "lib/opentelemetry/proto/**/*"
     - "vendor/**/*"
 
-Bundler/OrderedGems:
-  Exclude:
-    - gemfiles/**/*
-Lint/UnusedMethodArgument:
-  Enabled: false
-Lint/MissingSuper:
-  Enabled: false
-Lint/ConstantDefinitionInBlock:
-  Exclude:
-    - "test/**/*"
-Style/StringConcatenation:
-  Exclude:
-    - "test/**/*"
-Metrics/AbcSize:
+Metrics/CyclomaticComplexity:
   Enabled: false
-Layout/LineLength:
+Metrics/PerceivedComplexity:
   Enabled: false
 Metrics/MethodLength:
-  Max: 20
-Metrics/ParameterLists:
   Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Bundler/OrderedGems:
+  Exclude:
+    - gemfiles/**/*
 Style/FrozenStringLiteralComment:
   Exclude:
     - gemfiles/**/*

exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics_exporter.rb

@@ -26,7 +26,7 @@ module OpenTelemetry
   module Exporter
     module OTLP
       # An OpenTelemetry metrics exporter that sends metrics over HTTP as Protobuf encoded OTLP ExportMetricsServiceRequest.
-      class MetricsExporter < ::OpenTelemetry::SDK::Metrics::Export::MetricReader # rubocop:disable Metrics/ClassLength
+      class MetricsExporter < ::OpenTelemetry::SDK::Metrics::Export::MetricReader
         include Util
 
         attr_reader :metric_snapshots
@@ -90,7 +90,7 @@ def export(metrics, timeout: nil)
           end
         end
 
-        def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+        def send_bytes(bytes, timeout:)
           return FAILURE if bytes.nil?
 
           request = Net::HTTP::Post.new(@path)
@@ -184,7 +184,7 @@ def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity,
           @http.write_timeout = @timeout if WRITE_TIMEOUT_SUPPORTED
         end
 
-        def encode(metrics_data) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
+        def encode(metrics_data)
           Opentelemetry::Proto::Collector::Metrics::V1::ExportMetricsServiceRequest.encode(
             Opentelemetry::Proto::Collector::Metrics::V1::ExportMetricsServiceRequest.new(
               resource_metrics: metrics_data
@@ -218,7 +218,7 @@ def encode(metrics_data) # rubocop:disable Metrics/MethodLength, Metrics/Cycloma
         # current metric sdk only implements instrument: :counter -> :sum, :histogram -> :histogram
         #
         # metrics [MetricData]
-        def as_otlp_metrics(metrics) # rubocop:disable Metrics/MethodLength
+        def as_otlp_metrics(metrics)
           case metrics.instrument_kind
           when :observable_gauge
             Opentelemetry::Proto::Metrics::V1::Metric.new(

exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/util.rb

@@ -96,7 +96,7 @@ def parse_headers(raw)
           end
         end
 
-        def backoff?(retry_count:, reason:, retry_after: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        def backoff?(retry_count:, reason:, retry_after: nil)
           return false if retry_count > RETRY_COUNT
 
           sleep_interval = nil

metrics_api/lib/opentelemetry/metrics/instrument/counter.rb

@@ -16,7 +16,7 @@ class Counter
         #   Values must be non-nil and (array of) string, boolean or numeric type.
         #   Array values must not contain nil elements and all elements must be of
         #   the same basic type (string, numeric, boolean).
-        def add(increment, attributes: nil); end
+        def add(increment, attributes: {}); end
       end
     end
   end

metrics_api/lib/opentelemetry/metrics/instrument/histogram.rb

@@ -16,7 +16,7 @@ class Histogram
         #   Values must be non-nil and (array of) string, boolean or numeric type.
         #   Array values must not contain nil elements and all elements must be of
         #   the same basic type (string, numeric, boolean).
-        def record(amount, attributes: nil); end
+        def record(amount, attributes: {}); end
       end
     end
   end

metrics_api/lib/opentelemetry/metrics/instrument/up_down_counter.rb

@@ -16,7 +16,7 @@ class UpDownCounter
         #   Values must be non-nil and (array of) string, boolean or numeric type.
         #   Array values must not contain nil elements and all elements must be of
         #   the same basic type (string, numeric, boolean).
-        def add(amount, attributes: nil); end
+        def add(amount, attributes: {}); end
       end
     end
   end

metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/histogram.rb

@@ -24,7 +24,7 @@ def instrument_kind
           #   Values must be non-nil and (array of) string, boolean or numeric type.
           #   Array values must not contain nil elements and all elements must be of
           #   the same basic type (string, numeric, boolean).
-          def record(amount, attributes: nil)
+          def record(amount, attributes: {})
             update(amount, attributes)
             nil
           rescue StandardError => e

metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/up_down_counter.rb

@@ -24,7 +24,7 @@ def instrument_kind
           #   Values must be non-nil and (array of) string, boolean or numeric type.
           #   Array values must not contain nil elements and all elements must be of
           #   the same basic type (string, numeric, boolean).
-          def add(amount, attributes: nil)
+          def add(amount, attributes: {})
             update(amount, attributes)
             nil
           rescue StandardError => e