Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add csv as a dependency for Ruby 3.4 #1648

Conversation

michaelherold
Copy link

csv has been a default gem for a long while. In Ruby 3.4, it will stop being a default gem and will need to be explicitly required as a dependency.

warning: /opt/rubies/3.3.1/lib/ruby/3.3.0/csv.rb was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of opentelemetry-exporter-otlp-0.26.1 to add csv into its gemspec.

This change adds it as a dependency for the OTLP exporter since it makes use of the library. It uses the same version constraint as the Zipkin exporter for consistency.

See eb89cd6 for a similar change.

csv has been a default gem for a long while. In Ruby 3.4, it will stop
being a default gem and will need to be explicitly required as a
dependency.

This change adds it as a dependency for the OTLP exporter since it makes
use of the library. It uses the same version constraint as the Zipkin
exporter for consistency.
@kaylareopelle
Copy link
Contributor

Thanks for submitting this PR, @michaelherold! CSV is no longer a dependency of opentelemetry-exporter-otlp. If you update the gem to version 0.26.2 or above, the warning should go away.

@michaelherold
Copy link
Author

Hi @kaylareopelle! I double checked when I submitted and this is where the require happens. I haven't vetted when or where it is used, though; perhaps it's not used anywhere but the require was left behind?

@kaylareopelle
Copy link
Contributor

Ah, thank you! That link was very helpful. That file is for the opentelemetry-exporter-otlp-metrics gem, not the opentelemetry-exporter-otlp gem.

It looks like we're not using the CSV library in gem anymore, so I think the require was left behind.

Could you update this PR to remove the require 'csv' line from exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics_exporter.rb?

Copy link
Contributor

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@kaylareopelle
Copy link
Contributor

Hi, @michaelherold - The require 'csv' line will be removed by #1670

The warning will still appear on opentelemetry-exporter-otlp-0.26.1. The warning should no longer be reported on versions 0.26.2+ versions of that gem, as well as opentelemetry-exporter-otlp-metrics (when it is released).

@kaylareopelle kaylareopelle reopened this Aug 9, 2024
@github-actions github-actions bot removed the stale label Aug 10, 2024
@kaylareopelle
Copy link
Contributor

Closing, as #1670 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants