fix: ForwardingLogger should foward block param

[BrianHawley]

Also added tests to verify the default forwarding logger level, and to make sure it actually forwards logs.

Fixes #1599

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: BrianHawley / name: Brian Hawley (07efd23, d287a02)

[arielvalentin]

@BrianHawley please review the EasyCLA.

If you accept it, we will proceed with a review of this PR.

Thank you.

[BrianHawley]

@arielvalentin license accepted, thanks.

[szechyjs]

This seems to also be busted when using Ougai as the logger.

[adamk9k]

This introduced a bug if the logger used is Semantic Logger

OpenTelemetry error: no block given (yield)

coming from https://github.com/open-telemetry/opentelemetry-ruby/blob/main/sdk/lib/opentelemetry/sdk/forwarding_logger.rb#L41

[kaylareopelle]

Thanks, @adamk9k! I'll open an issue for this to take a closer look. If you know what needs to be done to fix the problem, please feel free to open a PR.

[adamk9k]

Thanks, @adamk9k! I'll open an issue for this to take a closer look. If you know what needs to be done to fix the problem, please feel free to open a PR.

Thank you @kaylareopelle in the meantime I've figured out what the issue was. It was coming from common/lib/opentelemetry/common/utilities.rb version 0.20.0 when it looked like this

def untraced
  Context.with_value(UNTRACED_KEY, true) do |ctx, _|
    yield ctx
  end
end

upgrading to 0.21.0 that includes this #1634 fixed it.

[kaylareopelle]

@adamk9k, that's great news! It sounds like nothing further needs to be done, and #1738 can be closed. Is that correct?

[adamk9k]

@kaylareopelle yes, thank you and sorry for the noise.

[kaylareopelle]

@adamk9k, no problem! Thanks for the update!