Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rubocop alignment update #1529

Merged
merged 1 commit into from
Oct 7, 2023
Merged

chore: Rubocop alignment update #1529

merged 1 commit into from
Oct 7, 2023

Conversation

kaylareopelle
Copy link
Contributor

This PR resolves the following Rubocop offense:

lib/opentelemetry/instrumentation/registry.rb:74:20: C: [Correctable] Layout/MultilineMethodCallIndentation: Align &.instance with .detect on line 73.
                   &.instance
                   ^^^^^^^^^^

@kaylareopelle kaylareopelle mentioned this pull request Oct 4, 2023
Merged
robbkidd
robbkidd approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to line up

@robbkidd
Copy link
Member

robbkidd commented Oct 5, 2023 •
edited
Loading

With 👍🏻 ✖️ 2️⃣, I'll go ahead and merge this whitespace change.

… except that I forgot that I'm only an Approver here and can't push the button. 🖖🏻

@mwear mwear merged commit 8b97474 into open-telemetry:main Oct 7, 2023
49 checks passed
@kaylareopelle kaylareopelle deleted the rubocop-updates branch October 11, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielvalentin arielvalentin arielvalentin approved these changes

@simi simi simi approved these changes

@robbkidd robbkidd robbkidd approved these changes

@mwear mwear mwear approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaylareopelle @robbkidd @arielvalentin @simi @mwear