fix: performance regression in_span (#1492)

* fix: performance regression in_span * chore: disable bad cop
open-telemetry · Aug 15, 2023 · d003724 · d003724
1 parent ccad50f
commit d003724
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/api/.rubocop.yml b/api/.rubocop.yml
@@ -24,3 +24,5 @@ Style/StringConcatenation:
     - "test/**/*"
 Style/ModuleFunction:
   Enabled: false
+Style/ExplicitBlockArgument:
+  Enabled: false
diff --git a/api/lib/opentelemetry/trace/tracer.rb b/api/lib/opentelemetry/trace/tracer.rb
@@ -34,7 +34,7 @@ class Tracer
       def in_span(name, attributes: nil, links: nil, start_timestamp: nil, kind: nil, &block)
         span = nil
         span = start_span(name, attributes: attributes, links: links, start_timestamp: start_timestamp, kind: kind)
-        Trace.with_span(span, &block)
+        Trace.with_span(span) { |s, c| yield s, c }
       rescue Exception => e # rubocop:disable Lint/RescueException
         span&.record_exception(e)
         span&.status = Status.error("Unhandled exception of type: #{e.class}")