Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values #5034

Merged
merged 4 commits into from
Oct 3, 2024
+2 −1
Merged

fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values #5034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98cd591
Changed error logging to warnings for unknown OTEL_NODE_RESOURCE_DETE…
RichardChukwu Oct 2, 2024
6e8b9a1
Update CHANGELOG.md
RichardChukwu Oct 3, 2024
fa4956e
Update CHANGELOG.md
RichardChukwu Oct 3, 2024
d51bda9
Update experimental/CHANGELOG.md
pichlermarc Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ All notable changes to experimental packages in this project will be documented
* `appendResourcePathToUrlIfNeeded`
* `configureExporterTimeout`
* `invalidTimeout`
* fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values [#5034](https://github.com/open-telemetry/opentelemetry-js/pull/5034)

### :books: (Refine Doc)

Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-sdk-node/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
return resourceDetectorsFromEnv.flatMap(detector => {
const resourceDetector = resourceDetectors.get(detector);
if (!resourceDetector) {
diag.error(
diag.warn(

Check warning on line 57 in experimental/packages/opentelemetry-sdk-node/src/utils.ts

View check run for this annotation

Codecov / codecov/patch

experimental/packages/opentelemetry-sdk-node/src/utils.ts#L57 

Added line #L57 was not covered by tests
`Invalid resource detector "${detector}" specified in the environment variable OTEL_NODE_RESOURCE_DETECTORS`
);
}
Expand Down
Loading