refactor(instrumentation-http): replace SpanAttributes and MetricAttributes with Attributes
#5023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes with Attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5023 +/- ##
==========================================
+ Coverage 93.39% 93.94% +0.54%
==========================================
Files 46 310 +264
Lines 712 8138 +7426
Branches 120 1633 +1513
==========================================
+ Hits 665 7645 +6980
- Misses 47 493 +446 |
david-luna
commented
Sep 27, 2024
| @@ -331,7 +331,7 @@ export class HttpInstrumentation extends InstrumentationBase<HttpInstrumentation | |||
| request: http.ClientRequest, | |||
| span: Span, | |||
| startTime: HrTime, | |||
| metricAttributes: MetricAttributes | |||
| metricAttributes: Attributes | |||
There was a problem hiding this comment.
I wonder if we also need to change param names. But I think that would make it a breaking change.
There was a problem hiding this comment.
ah, I think that's fine here. The name here is actually helping us understand that the attributes here are intended for the metric data point. 🙂
david-luna
deleted the
dluna/4175-replace-sattrib-interfaces-http-instr
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Replaces
SpanAttributesandMetricsAttributeswithAttributes. Mote this is not marked as a breaking change since@opentelemetry/apidependency is already atv1.3.0and types do not break.Refs #4175
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
compile and ran the test suite for instrumentation
Checklist: