refactor(exporter-prometheus): replace MetricAttributes to Attributes #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDanielson
approved these changes
Sep 16, 2024
JamieDanielson
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
It looks like the discussion is happening on the referenced PR updating API versions, but want to clarify here. Because this package already depends on "@opentelemetry/api": "1.9.0", this is a refactor that does not depend on that other PR. The reference to the original PR is helpful for discussion. This is one of the changes that can happen inmain without breaking changes, vs the changes to add to next that require an update to API version.
pichlermarc
approved these changes
Sep 17, 2024
CHANGELOG.md
Outdated
| @@ -19,6 +19,8 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se | |||
|
|
|||
| ### :house: (Internal) | |||
|
|
|||
| * refactor(exporter-prometheus): replace `MetricAttributes` and `MetricAttributeValues` with `Attributes` and `AttributeValues` [#4993](https://github.com/open-telemetry/opentelemetry-js/pull/4993) | |||
There was a problem hiding this comment.
ah, this should go into ./experimental/CHANGELOG.md as we're just modifying a experimental package. 🙂
There was a problem hiding this comment.
thanks! I've moved the entry
david-luna
deleted the
dluna/4175-replace-attrib-interfaces-prometheus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Replaces
MetricsAttributesandMetricAttributeValuestoAttributesandAttributeValueRefs #4175
Short description of the changes
How Has This Been Tested?
Ran the test suite for the exporter