Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-metrics)!: drop View and Aggregation for options #4931

Merged

Merge branch 'next' into feat/remove-aggregation

e15b379
Select commit
Loading
Failed to load commit list.
Merged

feat(sdk-metrics)!: drop View and Aggregation for options #4931

Merge branch 'next' into feat/remove-aggregation
e15b379
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2024 in 1s

93.90% (-0.06%) compared to 32564ad

View this Pull Request on Codecov

93.90% (-0.06%) compared to 32564ad

Details

Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.90%. Comparing base (32564ad) to head (e15b379).
Report is 4 commits behind head on next.

Files with missing lines Patch % Lines
packages/sdk-metrics/src/view/AggregationOption.ts 87.50% 4 Missing ⚠️
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4931      +/-   ##
==========================================
- Coverage   93.96%   93.90%   -0.06%     
==========================================
  Files         310      311       +1     
  Lines        8147     8172      +25     
  Branches     1630     1643      +13     
==========================================
+ Hits         7655     7674      +19     
- Misses        492      498       +6     
Files with missing lines Coverage Δ
...etry-exporter-prometheus/src/PrometheusExporter.ts 96.34% <100.00%> (+0.04%) ⬆️
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 95.48% <100.00%> (ø)
packages/sdk-metrics/src/MeterProvider.ts 100.00% <100.00%> (ø)
...ages/sdk-metrics/src/export/AggregationSelector.ts 100.00% <100.00%> (ø)
packages/sdk-metrics/src/export/MetricReader.ts 100.00% <100.00%> (ø)
.../sdk-metrics/src/state/MeterProviderSharedState.ts 100.00% <100.00%> (ø)
packages/sdk-metrics/src/view/Aggregation.ts 100.00% <100.00%> (ø)
packages/sdk-metrics/src/view/View.ts 100.00% <100.00%> (ø)
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 91.42% <66.66%> (-1.33%) ⬇️
packages/sdk-metrics/src/view/AggregationOption.ts 87.50% <87.50%> (ø)

... and 1 file with indirect coverage changes