Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel-resources): replace deprecated spanAttributes #4428

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Update minimum API version to 1.1.0 in opentelemetry-resources
  • Replace deprecated SpanAttributes with Attributes

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests pass

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated

@JamieDanielson JamieDanielson marked this pull request as ready for review January 18, 2024 16:01
@JamieDanielson JamieDanielson requested a review from a team January 18, 2024 16:01
@JamieDanielson JamieDanielson self-assigned this Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #4428 (3792a7b) into next (543f0b4) will decrease coverage by 0.06%.
Report is 7 commits behind head on next.
The diff coverage is 96.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4428      +/-   ##
==========================================
- Coverage   92.24%   92.19%   -0.06%     
==========================================
  Files         332      324       -8     
  Lines        9437     9348      -89     
  Branches     1999     1968      -31     
==========================================
- Hits         8705     8618      -87     
+ Misses        732      730       -2     
Files Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 93.75% <100.00%> (+0.20%) ⬆️
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.75% <100.00%> (+0.83%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.23% <100.00%> (ø)
...mental/packages/otlp-transformer/src/logs/index.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.05% <100.00%> (+0.07%) ⬆️
...ckages/opentelemetry-core/src/common/attributes.ts 93.02% <100.00%> (-0.16%) ⬇️
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.87% <ø> (ø)
... and 4 more

... and 20 files with indirect coverage changes

@legendecas legendecas merged commit 0aba75c into open-telemetry:next Jan 22, 2024
19 checks passed
@JamieDanielson JamieDanielson deleted the jamie.update-next-resources-attributes branch January 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants